(Laravel) - force updating to a new number #9915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
reviewed
May 29, 2025
| while ($queries--) { | ||
| $row = World::query()->find(self::randomInt()); | ||
| $row->randomNumber = self::randomInt(); | ||
| $row->randomNumber = ($randomInt = self::randomInt()) !== $row->randomNumber ? $randomInt : $randomInt + 1; |
Contributor
There was a problem hiding this comment.
If $randomInt is 10000 this would fail, as 10001 is invalid.
Other frameworks generate a new random number instead.
Contributor
Author
There was a problem hiding this comment.
Thanks! was not aware of that requirement. I've updated the method accordingly.
msmith-techempower
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Laravel, if you attempt to update a Model but have made no changes to its data, it will not write to the database. See Eloquent@save().
While the chances are vanishingly small that this would happen enough times to significantly affect benchmarks, I wanted to remove noise from the benchmarks.